Swift smithy request unit test generation #50
Conversation
| .indent() | ||
| .call { block() } | ||
| .dedent() | ||
| // TODO:: fix indentation when `writeInline` retains indent |
There was a problem hiding this comment.
yes presumably it will, last I checked it hadn't made it into a release though.
| .indent() | ||
| .call { block() } | ||
| .dedent() | ||
| // TODO:: fix indentation when `writeInline` retains indent |
There was a problem hiding this comment.
yes presumably it will, last I checked it hadn't made it into a release though.
|
|
||
| private fun primitiveDecl(writer: SwiftWriter, shape: Shape, block: () -> Unit) { | ||
| var suffix = "" | ||
| when (shape.type) { |
There was a problem hiding this comment.
val suffix = when(shape.type) {
ShapeType.STRING -> { ... }
else -> ""
}| val memberShape: Shape | ||
| when (currShape) { | ||
| is StructureShape -> { | ||
| val member = if (currShape.asStructureShape().get().getMember(keyNode.value).isPresent) { |
There was a problem hiding this comment.
This is an odd if/else statement (which now that I look may have come from me and/or one of the other codebases).
Would be cleaner to just do something like:
val member = currShape.getMember(keyNode.value).orElseThrow {
CodegenException("unknown member ${currShape.id}.${keyNode.value}")
}
We already know currShape is a StructureShape so we should just rely on smart casting instead of checking if it's a structure shape again. Also since the else branch throws this is easier to follow intent.
| * Render a test class and unit tests for the specified [testCases] | ||
| */ | ||
| fun renderTestClass(testClassName: String) { | ||
| // writer.addImport(KotlinDependency.KOTLIN_TEST.namespace, "Test", "") |
There was a problem hiding this comment.
remove these commented out lines
Description of changes:
This PR follows 48 which covered ClientRuntime changes necessary to support http request unit testing.
This PR defines the base class
HttpProtocolTestGeneratorwhich is responsible for generating the request, response and error object unit tests. It also defines aHttpProtocolUnitTestGeneratorgeneric class which is then specialized to handle the request/response test cases. The HttpRequest test cases are handled throughHttpProtocolUnitTestRequestGenerator. Similar specialized class for response tests will be added later.This PR also includes a
ShapeValueGeneratorwhich renders instances of any shape. Unit tests are included for the same.Minor ClientRuntime changes to support this PR are also included.
The tests generator are not yet run (few compile errors in generated service client that need to be fixed), they do compile successfully.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.