Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Auth scheme changes #601
feat: Auth scheme changes #601
Changes from all commits
86c7d2c
5eb2c8d
75646fc
dd339a0
f5808fa
6371b28
9327f98
9b7b4c5
39b386e
d87e82f
ad8cd2c
61b79a6
cca514b
a05e6cd
1bd5ac5
99323e6
1f7d2ac
422721c
9e044dd
f7f9e0e
d54fda8
b0b7d9e
1794543
07ff3ca
e0a6146
dd4324b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is
any
orsome
better here? Do we expect this function to always return a single concrete type?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function always returns a single concrete type that conforms to
IdentityResolver
(or nil if none is configured for the given identity kind), but it's dependent on which kind of identity is passed in as the argument. Also, havingsome
keyword in protocols is not allowed in Swift. With these two factors combined, 'any' is used here.