Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add copyright notice extension point #765

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

sichanyoo
Copy link
Contributor

@sichanyoo sichanyoo commented Jun 19, 2024

Companion PR: awslabs/aws-sdk-swift#1581

Issue #

awslabs/aws-sdk-swift#1547

Description of changes

  • Adds customization point for copyright notice via smithy-build.json's copyrightNotice property, which gets read by SwiftSettings.

Scope

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sichanyoo sichanyoo requested a review from jbelkins June 26, 2024 17:06
Copy link
Contributor

@jbelkins jbelkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see Q

@sichanyoo sichanyoo requested a review from jbelkins June 27, 2024 18:53
@sichanyoo sichanyoo force-pushed the feat/copyright-notice-codegen branch from dd00d20 to f444349 Compare June 28, 2024 21:38
@sichanyoo sichanyoo merged commit ca7506d into main Jul 2, 2024
27 checks passed
@sichanyoo sichanyoo deleted the feat/copyright-notice-codegen branch July 2, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants