Export CONFIG_PREFIX_SEPARATOR from loadSharedConfigFiles (#992)

smithy-lang · Oct 6, 2023 · 719777c · 719777c
1 parent 58b25ce
commit 719777c
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 4 deletions.
diff --git a/.changeset/funny-hornets-dress.md b/.changeset/funny-hornets-dress.md
@@ -0,0 +1,5 @@
+---
+"@smithy/shared-ini-file-loader": patch
+---
+
+Export CONFIG_PREFIX_SEPARATOR from loadSharedConfigFiles
diff --git a/packages/shared-ini-file-loader/src/loadSharedConfigFiles.ts b/packages/shared-ini-file-loader/src/loadSharedConfigFiles.ts
@@ -30,6 +30,8 @@ export interface SharedConfigInit {
 
 const swallowError = () => ({});
 
+export const CONFIG_PREFIX_SEPARATOR = ".";
+
 export const loadSharedConfigFiles = async (init: SharedConfigInit = {}): Promise<SharedConfigFiles> => {
   const { filepath = getCredentialsFilepath(), configFilepath = getConfigFilepath() } = init;
 

diff --git a/packages/shared-ini-file-loader/src/parseIni.spec.ts b/packages/shared-ini-file-loader/src/parseIni.spec.ts
@@ -1,3 +1,4 @@
+import { CONFIG_PREFIX_SEPARATOR } from "./loadSharedConfigFiles";
 import { parseIni } from "./parseIni";
 
 describe(parseIni.name, () => {
@@ -99,7 +100,7 @@ describe(parseIni.name, () => {
       expect(parseIni(mockInput)).toStrictEqual({
         [mockProfileName]: {
           key: "value",
-          "subSection.subKey": "subValue",
+          [["subSection", "subKey"].join(CONFIG_PREFIX_SEPARATOR)]: "subValue",
         },
       });
 
@@ -112,11 +113,11 @@ describe(parseIni.name, () => {
       expect(parseIni(`${mockInput}${mockInput2}`)).toStrictEqual({
         [mockProfileName]: {
           key: "value",
-          "subSection.subKey": "subValue",
+          [["subSection", "subKey"].join(CONFIG_PREFIX_SEPARATOR)]: "subValue",
         },
         [mockProfileName2]: {
           key: "value2",
-          "subSection.subKey": "subValue2",
+          [["subSection", "subKey"].join(CONFIG_PREFIX_SEPARATOR)]: "subValue2",
         },
       });
     });

diff --git a/packages/shared-ini-file-loader/src/parseIni.ts b/packages/shared-ini-file-loader/src/parseIni.ts
@@ -1,5 +1,7 @@
 import { ParsedIniData } from "@smithy/types";
 
+import { CONFIG_PREFIX_SEPARATOR } from "./loadSharedConfigFiles";
+
 const profileNameBlockList = ["__proto__", "profile __proto__"];
 
 export const parseIni = (iniData: string): ParsedIniData => {
@@ -28,7 +30,7 @@ export const parseIni = (iniData: string): ParsedIniData => {
           currentSubSection = name;
         } else {
           map[currentSection] = map[currentSection] || {};
-          const key = currentSubSection ? `${currentSubSection}.${name}` : name;
+          const key = currentSubSection ? [currentSubSection, name].join(CONFIG_PREFIX_SEPARATOR) : name;
           map[currentSection][key] = value;
         }
       }