Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apply filtering when walking json arrays #1086

Merged
merged 1 commit into from
Nov 30, 2023
Merged

fix: apply filtering when walking json arrays #1086

merged 1 commit into from
Nov 30, 2023

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Nov 29, 2023 •
edited
Loading

_json is a recursive serde function for the default JSON protocol behavior. It was missing a recursive call when walking through an array type.

  • protocol tests passing in AWS SDK JSv3

@kuhe kuhe requested review from a team as code owners November 29, 2023 23:17
@kuhe kuhe requested a review from srchase November 29, 2023 23:17
@kuhe kuhe merged commit 07ff207 into smithy-lang:main Nov 30, 2023
7 checks passed
@kuhe kuhe deleted the fix/serde-json branch November 30, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@srchase srchase srchase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kuhe @srchase @trivikr