fix(codegen): use TopDownIndex::getContainedOperations() for operation iterations
#1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
reviewed
Dec 12, 2023
| ) { | ||
| Map<ShapeId, HttpAuthScheme> effectiveAuthSchemes = new TreeMap<>(); | ||
| var serviceEffectiveAuthSchemes = | ||
| serviceIndex.getEffectiveAuthSchemes(serviceShape, AuthSchemeMode.NO_AUTH_AWARE); | ||
| for (ShapeId shapeId : serviceEffectiveAuthSchemes.keySet()) { | ||
| effectiveAuthSchemes.put(shapeId, authIndex.getHttpAuthScheme(shapeId)); | ||
| } | ||
| for (var operation : serviceShape.getAllOperations()) { | ||
| for (var operation : topDownIndex.getContainedOperations(serviceShape)) { |
There was a problem hiding this comment.
is there anything going in place to warn that serviceShape.getAllOperations() is not how to get service operations? 😕
There was a problem hiding this comment.
Technically the javadoc for ServiceShape::getAllOperations() mentions that it doesn't contain everything and references TopDownIndex::getContainedOperations(), unfortunately there isn't a way to enforce it.
There was a problem hiding this comment.
Albeit there is documentation on smithy.io that documents using the TopDownIndex.
kuhe
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A.
Description of changes:
Use
TopDownIndex::getContainedOperations()for operation iterations.If one or more of the packages in the
/packagesdirectory has been modified, be sureyarn changeset addhas been run and its output hasbeen committed and included in this pull request. See CONTRIBUTING.md.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.