feat: omit endpoint params from generation in the client interface #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddsriv
changed the title
kuhe
reviewed
May 17, 2024
.../src/main/java/software/amazon/smithy/typescript/codegen/endpointsV2/OmitEndpointParams.java
Show resolved
Hide resolved
siddsriv
commented
May 17, 2024
.../src/main/java/software/amazon/smithy/typescript/codegen/endpointsV2/OmitEndpointParams.java
Show resolved
Hide resolved
kuhe
reviewed
May 17, 2024
.../src/main/java/software/amazon/smithy/typescript/codegen/endpointsV2/OmitEndpointParams.java
Outdated
Show resolved
Hide resolved
siddsriv
force-pushed
the
accId-ep-param
branch
5 times, most recently
from
a85f296 to
8d84186
Compare
kuhe
reviewed
Jun 21, 2024
.../src/main/java/software/amazon/smithy/typescript/codegen/endpointsV2/OmitEndpointParams.java
Outdated
Show resolved
Hide resolved
kuhe
reviewed
Jun 21, 2024
.../src/main/java/software/amazon/smithy/typescript/codegen/endpointsV2/OmitEndpointParams.java
Show resolved
Hide resolved
kuhe
approved these changes
Jun 21, 2024
JordonPhillips
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Internal JS-4633
Part 2
Description of changes:
Omits (a collection of) Endpoint params from being generated into the
ClientInputEndpointParametersinterface. This collection can be used for omission from other interfaces as well accordingly.Partner PR in JSv3: aws/aws-sdk-js-v3#6035
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.