Process String Array parameters in Endpoints #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
force-pushed
the
string-array-ruleset-param-finder
branch
from
ca8279c to
b04921e
Compare
trivikr
changed the title
trivikr
force-pushed
the
string-array-ruleset-param-finder
branch
from
dee40fc to
7f00d08
Compare
|
There's no diff in codegen, since no models contain StringArray parameters. Testing will be done in util-endpoints/src/mocks, similar to #1374 |
sugmanue
approved these changes
Aug 27, 2024
.../src/main/java/software/amazon/smithy/typescript/codegen/endpointsV2/ParameterGenerator.java
Outdated
Show resolved
Hide resolved
.../src/main/java/software/amazon/smithy/typescript/codegen/endpointsV2/ParameterGenerator.java
Outdated
Show resolved
Hide resolved
sugmanue
approved these changes
Aug 27, 2024
kuhe
reviewed
Aug 27, 2024
.../main/java/software/amazon/smithy/typescript/codegen/endpointsV2/RuleSetParameterFinder.java
Outdated
Show resolved
Hide resolved
kuhe
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Internal JS-5234
Description of changes:
Process String Array parameters in Endpoints
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.