Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for error cause in transient error checks #1461

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

jtmthf
Copy link
Contributor

@jtmthf jtmthf commented Nov 26, 2024

*Issue #1446

Description of changes:

Updates isTransientError to recursively check the cause property if the underlying error is also transient. This continues until either the error cause chain is exhausted or a causing error is determined to be transient. This correctly annotates node http2 errors which wrap ETIMEDOUT errors.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jtmthf jtmthf requested a review from a team as a code owner November 26, 2024 16:29
@kuhe
Copy link
Contributor

kuhe commented Dec 2, 2024

I'll be merging this but I don't have a time estimate for the release since it is currently re:Invent week with AWS.

@kuhe kuhe merged commit b52b4e8 into smithy-lang:main Dec 2, 2024
11 checks passed
@kuhe
Copy link
Contributor

kuhe commented Dec 9, 2024

Published in 3.0.11 of @smithy/service-error-classification.

https://github.com/smithy-lang/smithy-typescript/blob/main/packages/service-error-classification/CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants