chore(codegen): resolve obj and array JS literals from JMESPath types for waiters #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
reviewed
Nov 26, 2024
...degen/src/main/java/software/amazon/smithy/typescript/codegen/TypeScriptJmesPathVisitor.java
Outdated
Show resolved
Hide resolved
kuhe
reviewed
Nov 26, 2024
...degen/src/main/java/software/amazon/smithy/typescript/codegen/TypeScriptJmesPathVisitor.java
Outdated
Show resolved
Hide resolved
kuhe
reviewed
Dec 3, 2024
...degen/src/main/java/software/amazon/smithy/typescript/codegen/TypeScriptJmesPathVisitor.java
Outdated
Show resolved
Hide resolved
siddsriv
force-pushed
the
waiter-literals
branch
from
a0373db to
3d0ceed
Compare
kuhe
approved these changes
Dec 9, 2024
siddsriv
force-pushed
the
waiter-literals
branch
from
3d0ceed to
7dc05bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Internal JS-5495
Description of changes:
completing a TODO: resolves JMESPath object and array types as JS literals
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.