pass client config to loadNodeConfig calls #1471
Merged
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
trivikr
approved these changes
Dec 16, 2024
Comment on lines
+1
to
+2
| --- | ||
| --- |
There was a problem hiding this comment.
nit: empty changeset is not needed is only Java file are edited.
There was a problem hiding this comment.
Yeah, I agree it's not necessary, but I sometimes create one to remind myself of what changes are pending since it creates an item in the changeset folder associated with this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the client config object to loadNodeConfig calls.
This does nothing for non-AWS clients, but allows code-level, i.e. client-scoped AWS profile value to be set.