Process Map in function parameter list #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
force-pushed
the
function-params-list-object
branch
3 times, most recently
from
6ecad85 to
825d993
Compare
trivikr
force-pushed
the
function-params-list-object
branch
from
825d993 to
0b6e181
Compare
kuhe
reviewed
Dec 16, 2024
...typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/CodegenUtils.java
Outdated
Show resolved
Hide resolved
kuhe
reviewed
Dec 16, 2024
...typescript-codegen/src/main/java/software/amazon/smithy/typescript/codegen/CodegenUtils.java
Outdated
Show resolved
Hide resolved
kuhe
approved these changes
Dec 16, 2024
Co-authored-by: George Fu <kuhe@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Required for aws/aws-sdk-js-v3#6698
Description of changes:
Process Map in function parameter list
Code generation tested in aws/aws-sdk-js-v3@
33c0943(#6698)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.