Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default import package.json for spec compatibility #209

Merged
merged 3 commits into from
Sep 14, 2020

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Sep 8, 2020

Issue #, if available:
Refs: aws/aws-sdk-js-v3#1504

Description of changes:
Default import package.json for spec compatibility

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as draft September 9, 2020 15:30
@trivikr
Copy link
Contributor Author

trivikr commented Sep 9, 2020

Converted to draft since there's an open question about default import vs whole module import in aws/aws-sdk-js-v3#1505 (review)

@trivikr
Copy link
Contributor Author

trivikr commented Sep 9, 2020

This PR would be rebased and set to ready for review after #212 is merged.

Co-authored-by: Raphael Varonos <r.varonos@gmail.com>
@trivikr trivikr marked this pull request as ready for review September 11, 2020 18:39
@trivikr trivikr merged commit 4266f89 into smithy-lang:master Sep 14, 2020
@trivikr trivikr deleted the support-webpack-5 branch September 14, 2020 23:04
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
Co-authored-by: Raphael Varonos <r.varonos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants