Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-test): compare xml payload with outmost node #433

Merged
merged 1 commit into from
Sep 29, 2021
Merged

fix(protocol-test): compare xml payload with outmost node #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .../java/software/amazon/smithy/typescript/codegen/integration/DocumentMemberSerVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,14 @@ public DocumentMemberSerVisitor(
this.defaultTimestampFormat = defaultTimestampFormat;
}

/**
* @return the member this visitor is being run against. Used to discover member-applied
* traits, such as @xmlName. Can be, and defaults, to, null.
*/
protected MemberShape getMemberShape() {
return null;
}

/**
* Gets the generation context.
*
Expand Down
2 changes: 1 addition & 1 deletion ...en/src/main/resources/software/amazon/smithy/typescript/codegen/protocol-test-xml-stub.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const compareEquivalentXmlBodies = (
parsedObjToReturn[key] = parsedObjToReturn[textNodeName];
delete parsedObjToReturn[textNodeName];
}
return parsedObjToReturn;
return parsedObj;
};

const expectedParts = parseXmlBody(expectedBody);
Expand Down