Add ability to ts-ignore a default import #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
approved these changes
Oct 6, 2021
gosar
reviewed
Oct 6, 2021
...-codegen/src/test/java/software/amazon/smithy/typescript/codegen/ImportDeclarationsTest.java
Outdated
Show resolved
Hide resolved
When importing package.json outside srcDir, TypeScript will fail checks even though compiled JS will work fine. Annotating the import with @ts-ignore, and using eslint-disable-line to prevent import reordering from separating the ts-ignore comment from the line being ignored, allows us to suppress these errors without reorganizing the generated module and without postprocessing the generator output.
adamthom-amzn
force-pushed
the
ignore-import
branch
from
859c97f to
dd1ef82
Compare
gosar
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
When importing package.json outside srcDir, TypeScript will fail checks even
though compiled JS will work fine. Annotating the import with @ts-ignore,
and using eslint-disable-line to prevent import reordering from separating
the ts-ignore comment from the line being ignored, allows us to suppress these
errors without reorganizing the generated module and without postprocessing
the generator output.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.