Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use bare-bones and aggregated instead of modular/non-modular #457

Merged
merged 5 commits into from
Oct 25, 2021

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Oct 24, 2021

Issue #, if available:
Refs: aws/aws-sdk-js-v3#2205

Description of changes:
In March 2021, the AWS SDK for JavaScript team had decided to use bare-bones/aggregated instead of modular/non-modular for clients to avoid confusion. This change was done in aws-sdk-js-v3, but not in smithy-ts side.

This PR updates:

  • ServiceGenerator to ServiceBareBonesClientGenerator
  • NonModularServiceGenerator to ServiceAggregateClientGenerator
  • The variable names with prefix nonModular* to aggregated*

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr merged commit 553e700 into smithy-lang:main Oct 25, 2021
@trivikr trivikr deleted the update-client-generator-names branch October 25, 2021 17:08
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants