Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(endpoint): do not modify context param names #617

Merged
merged 1 commit into from
Oct 19, 2022
Merged

fix(endpoint): do not modify context param names #617

merged 1 commit into from
Oct 19, 2022

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Oct 19, 2022

don't rename context params like Bucket to bucket.

@kuhe kuhe requested a review from a team as a code owner October 19, 2022 03:07
@kuhe
Copy link
Contributor Author

kuhe commented Oct 19, 2022

tested with yarn test:e2e in client-s3 with

AWS_SMOKE_TEST_REGION=... \
AWS_SMOKE_TEST_BUCKET=... \
AWS_SMOKE_TEST_MRAP_ARN=... \

@trivikr trivikr merged commit f345347 into smithy-lang:main Oct 19, 2022
@kuhe kuhe deleted the fix/endpoints-2.0 branch October 19, 2022 06:05
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
@kuhe @srchase
fix(endpoint): do not modify context param names (smithy-lang#617)
6dc387b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuhe @trivikr