Compile regexes on UnaryFunctionCall #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesziemer
approved these changes
May 8, 2023
srchase
force-pushed
the
unary-function-call-regexes
branch
from
52ae1ba to
5b396ac
Compare
This was referenced May 9, 2023
kuhe
reviewed
May 9, 2023
| /** | ||
| * For handling expressions that may be unary function calls. | ||
| */ | ||
| public abstract class UnaryFunctionCall { |
There was a problem hiding this comment.
this is used in JSv3, could you add it there?
There was a problem hiding this comment.
Yes, added as part of aws/aws-sdk-js-v3#4712
kuhe
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unused UnaryFunctionCall class
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.