Update codegen for package migration #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
approved these changes
Jun 23, 2023
srchase
force-pushed
the
codegen-for-package-migration
branch
from
e0ee06e to
dfd017c
Compare
srchase
force-pushed
the
codegen-for-package-migration
branch
from
dfd017c to
01ad19e
Compare
AndrewFossAWS
approved these changes
Jun 28, 2023
milesziemer
reviewed
Jun 28, 2023
There was a problem hiding this comment.
Some of the writer.addImports are updated to use the TypeScriptDependency param instead of package name, where others that still are using the package name have just changed the name to use the smithy scope for example. Can we update those too?
There was a problem hiding this comment.
Some of these are still named AWS, even though they're presumably generic client dependencies (ie. smithy scope). Can we change them or is a reason to keep it like that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates codegen to use the
@smithyNPM packages that were added in #773 and #790.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.