Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @smithy/protocol-http import in HttpApiKeyAuth spec #817

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

jhecking
Copy link
Contributor

@jhecking jhecking commented Jul 7, 2023

Issue #, if available:

Description of changes:

Without this fix, building the generated SSDK fails:

$ concurrently 'yarn:build:cjs' 'yarn:build:es' 'yarn:build:types'
$ tsc -p tsconfig.es.json
$ tsc -p tsconfig.types.json
$ tsc -p tsconfig.cjs.json
[build:types] src/middleware/HttpApiKeyAuth/index.spec.ts(4,29): error TS2307: Cannot find module 'smithy/protocol-http' or its corresponding type declarations.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[build:types] yarn run build:types exited with code 2
[build:es] src/middleware/HttpApiKeyAuth/index.spec.ts(4,29): error TS2307: Cannot find module 'smithy/protocol-http' or its corresponding type declarations.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[build:cjs] src/middleware/HttpApiKeyAuth/index.spec.ts(4,29): error TS2307: Cannot find module 'smithy/protocol-http' or its corresponding type declarations.
[build:es] yarn run build:es exited with code 2
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[build:cjs] yarn run build:cjs exited with code 2
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed.
Exit code: 1
Command: /Users/jhecking/.nvm/versions/node/v16.19.0/bin/node
Arguments: /opt/homebrew/Cellar/yarn/1.22.19/libexec/lib/cli.js run build
Directory: /Users/jhecking/path/to/project
Output:

Smithy version used:

smithyVersion=1.33.0
smithyTypeScriptVersion=0.17.0
smithyGradleVersion=0.7.0

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jhecking jhecking requested review from a team as code owners July 7, 2023 11:44
@srchase srchase merged commit 06ff4f7 into smithy-lang:main Jul 7, 2023
@srchase
Copy link
Contributor

srchase commented Jul 7, 2023

Thanks for the fix!

@jhecking jhecking deleted the patch-1 branch July 8, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants