Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimentalIdentityAndAuth): add getEndpointParameterInstructions() to smithy context #955

Conversation

syall
Copy link
Contributor

@syall syall commented Sep 23, 2023

Issue #, if available:

N/A.

Description of changes:

Add getEndpointParameterInstructions() to smithy context.

Testing:

Note: all of the changes are gated by experimentalIdentityAndAuth flag

The codegen diff adds the endpointRuleSet context with the getEndpointParameterInstructions per operation, and will be used in the S3 and EventBridge @endpointRuleset HttpAuthSchemeProviders in aws/aws-sdk-js-v3#5231.

diff --color -Nur /Users/yuasteve/development/ts-ia/smithy-typescript/smithy-typescript-codegen-test/build_old/smithyprojections/smithy-typescript-codegen-test/client-experimental-identity-and-auth/typescript-codegen/src/commands/CreateCityCommand.ts /Users/yuasteve/development/ts-ia/smithy-typescript/smithy-typescript-codegen-test/build/smithyprojections/smithy-typescript-codegen-test/client-experimental-identity-and-auth/typescript-codegen/src/commands/CreateCityCommand.ts
--- /Users/yuasteve/development/ts-ia/smithy-typescript/smithy-typescript-codegen-test/build_old/smithyprojections/smithy-typescript-codegen-test/client-experimental-identity-and-auth/typescript-codegen/src/commands/CreateCityCommand.ts	2023-09-24 00:00:25
+++ /Users/yuasteve/development/ts-ia/smithy-typescript/smithy-typescript-codegen-test/build/smithyprojections/smithy-typescript-codegen-test/client-experimental-identity-and-auth/typescript-codegen/src/commands/CreateCityCommand.ts	2023-09-24 00:02:02
@@ -101,6 +101,9 @@
       [SMITHY_CONTEXT_KEY]: {
         service: "Weather",
         operation: "CreateCity",
+        endpointRuleSet: {
+          getEndpointParameterInstructions: CreateCityCommand.getEndpointParameterInstructions,
+        },
       },
     }
     const { requestHandler } = configuration;

If one or more of the packages in the /packages directory has been modified, be sure yarn changeset add has been run and its output has
been committed and included in this pull request. See CONTRIBUTING.md.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@syall syall force-pushed the add-getEndpointParameterInstructions-to-context branch from 69ffd82 to b42b666 Compare September 23, 2023 23:03
@syall syall force-pushed the add-getEndpointParameterInstructions-to-context branch from b42b666 to 2d06d8c Compare September 24, 2023 07:03
@syall
Copy link
Contributor Author

syall commented Sep 25, 2023

Closed in favor of: #956, #957, aws/aws-sdk-js-v3#5231

@syall syall closed this Sep 25, 2023
@syall syall deleted the add-getEndpointParameterInstructions-to-context branch October 10, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant