Remove warning when PATCH is idempotent

smithy-lang · Jul 19, 2021 · ae3af5e · ae3af5e
1 parent cf1ecbd
commit ae3af5e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/...java/software/amazon/smithy/model/validation/validators/HttpMethodSemanticsValidator.java b/...java/software/amazon/smithy/model/validation/validators/HttpMethodSemanticsValidator.java
@@ -58,7 +58,7 @@ public final class HttpMethodSemanticsValidator extends AbstractValidator {
             "POST", new HttpMethodSemantics(false, null, true),
             "DELETE", new HttpMethodSemantics(false, true, false),
             "PUT", new HttpMethodSemantics(false, true, true),
-            "PATCH", new HttpMethodSemantics(false, false, true));
+            "PATCH", new HttpMethodSemantics(false, null, true));
 
     @Override
     public List<ValidationEvent> validate(Model model) {

diff --git a/...s/software/amazon/smithy/model/errorfiles/validators/http-method-semantics-validator.json b/...s/software/amazon/smithy/model/errorfiles/validators/http-method-semantics-validator.json
@@ -172,6 +172,16 @@
                     "target": "smithy.api#String"
                 }
             }
+        },
+        "ns.foo#N": {
+            "type": "operation",
+            "traits": {
+                "smithy.api#http": {
+                    "method": "PATCH",
+                    "uri": "/E"
+                },
+                "smithy.api#idempotent": {}
+            }
         }
     }
 }