Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codewriter.popState does not respect the expression character #647

Closed
rcoh opened this issue Dec 1, 2020 · 0 comments · Fixed by #648
Closed

Codewriter.popState does not respect the expression character #647

rcoh opened this issue Dec 1, 2020 · 0 comments · Fixed by #648
Assignees
@mtdowling
Labels
bug This issue is a bug.

Comments

@rcoh
Copy link
Contributor

rcoh commented Dec 1, 2020

https://github.com/awslabs/smithy/blob/master/smithy-utils/src/main/java/software/amazon/smithy/utils/CodeWriter.java#L657

When a non-expression character is used in a named section, the call to writeOptional does not respect expressionStart.

Either:

  • expressionStart should be used
  • writeWithoutFormatting should be used instead of writeOptional
@mtdowling mtdowling added the bug This issue is a bug. label Dec 1, 2020
@mtdowling mtdowling self-assigned this Dec 1, 2020
mtdowling added a commit that referenced this issue Dec 1, 2020
@mtdowling
Fix popState to honor expression start char
c62f198 
Fixes #647
@mtdowling mtdowling mentioned this issue Dec 1, 2020
Merged
mtdowling added a commit that referenced this issue Dec 2, 2020
@mtdowling
Fix popState to honor expression start char
43593eb 
Fixes #647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtdowling mtdowling

Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix popState to honor expression start char smithy-lang/smithy
2 participants
@mtdowling @rcoh