Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream CLI messages rather than buffer until the end #797

Closed
mtdowling opened this issue May 11, 2021 · 0 comments · Fixed by #801
Closed

Stream CLI messages rather than buffer until the end #797

mtdowling opened this issue May 11, 2021 · 0 comments · Fixed by #801
Labels
feature-request A feature should be added or improved.

Comments

@mtdowling
Copy link
Member

When using the CLI, errors, warnings, and other validation events are buffered in memory until the model is fully loaded and validated/selected. When validating hundreds of thousands of shapes, there is a significant delay before messages are written to the console, and validation events can eat up a lot of memory. A nice feature would be to stream messages as they occur.

Note that this feature likely requires plumbing in various places in Smithy.
@mtdowling mtdowling added the feature-request A feature should be added or improved. label May 11, 2021
mtdowling added a commit that referenced this issue May 14, 2021
@mtdowling
Make CLI output improvements
93b9bae 
This commit closes #797

The CLI will now log validation events as they occur rather than waiting
until all events are encountered before writing them. This makes the CLI
a bit more responsive when validating hundreds of thousands of shapes.

Other improvements were added to the CLI output as well, including the
--severity parameter to set the minimum severity to display in output.
This can significantly cut down on noise when model files emit things <
DANGER.
@mtdowling mtdowling mentioned this issue May 14, 2021
Merged
mtdowling added a commit that referenced this issue May 17, 2021
@mtdowling
Make CLI output improvements
a29d73f 
This commit closes #797

The CLI will now log validation events as they occur rather than waiting
until all events are encountered before writing them. This makes the CLI
a bit more responsive when validating hundreds of thousands of shapes.

Other improvements were added to the CLI output as well, including the
--severity parameter to set the minimum severity to display in output.
This can significantly cut down on noise when model files emit things <
DANGER.
mtdowling added a commit that referenced this issue May 17, 2021
@mtdowling
Make CLI output improvements
8a4d315 
This commit closes #797

The CLI will now log validation events as they occur rather than waiting
until all events are encountered before writing them. This makes the CLI
a bit more responsive when validating hundreds of thousands of shapes.

Other improvements were added to the CLI output as well, including the
--severity parameter to set the minimum severity to display in output.
This can significantly cut down on noise when model files emit things <
DANGER.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make CLI output improvements smithy-lang/smithy
1 participant
@mtdowling