Set AWS SDK for Rust Language to Rust #1190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AWS SDK for Rust language was marked as Kotlin, but looking at the [Github repository page](https://github.com/awslabs/aws-sdk-rust) the implementation is entirely in Rust. I've updated the language entry to Rust from Kotlin.
|
Thanks for the PR! This is definitely a confusing bit of documentation. The actual code generator for the AWS rust sdk is entirely contained within the smithy-rs repo, which is different than some of the other language implementations. aws-sdk-rust is where they put all the built aws clients, so there isn't any generator code there. I put up a separate PR to clarify this issue, let me know if it needs any more changes. |
|
Sounds good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The AWS SDK for Rust language was marked as Kotlin, but looking at the Github repository page the implementation is entirely in Rust. I've updated the language entry to Rust from Kotlin.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.