Add tests for DowngradeToV1 #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
force-pushed
the
add-1.0-serialization-option-test
branch
2 times, most recently
from
7cae62a to
7397255
Compare
syall
changed the title
syall
force-pushed
the
add-1.0-serialization-option-test
branch
from
7397255 to
f2dbe5f
Compare
mtdowling
reviewed
Sep 19, 2022
smithy-model/src/main/java/software/amazon/smithy/model/transform/DowngradeToV1.java
Outdated
Show resolved
Hide resolved
syall
force-pushed
the
add-1.0-serialization-option-test
branch
from
f2dbe5f to
3e5ae6d
Compare
syall
requested review from
mtdowling and
a team
and removed request for
mtdowling
gosar
reviewed
Sep 20, 2022
smithy-model/src/test/java/software/amazon/smithy/model/transform/DowngradeToV1Test.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/transform/DowngradeToV1Test.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/transform/DowngradeToV1Test.java
Outdated
Show resolved
Hide resolved
...resources/software/amazon/smithy/model/shapes/ast-serialization/cases/box-member-1.0-to.json
Outdated
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/shapes/ModelSerializerTest.java
Outdated
Show resolved
Hide resolved
syall
force-pushed
the
add-1.0-serialization-option-test
branch
from
3e5ae6d to
841053c
Compare
gosar
reviewed
Sep 21, 2022
smithy-model/src/main/java/software/amazon/smithy/model/transform/DowngradeToV1.java
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/transform/DowngradeToV1Test.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/shapes/ModelSerializerTest.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/shapes/ModelSerializerTest.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/shapes/ModelSerializerTest.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/shapes/ModelSerializerTest.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/shapes/ModelSerializerTest.java
Outdated
Show resolved
Hide resolved
smithy-model/src/test/java/software/amazon/smithy/model/shapes/ModelSerializerTest.java
Outdated
Show resolved
Hide resolved
gosar
approved these changes
Sep 21, 2022
syall
force-pushed
the
add-1.0-serialization-option-test
branch
from
841053c to
c5f57a0
Compare
This commit adds the following test cases for 1.0 roundtrip serialization for `@enum` and `@box` traits (refactor test factories). Also, added a string shape with the `@enum` trait for the 2.0 enum roundtrip test case. Updated removing unnecessary defaults to fix `MemberShape` cases with comments to explain each case.
syall
force-pushed
the
add-1.0-serialization-option-test
branch
from
c5f57a0 to
b44e6ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Also addressed some comments from the original DowngradeToV1 PR: #1403
This commit adds the following test cases for 1.0 roundtrip serialization for
@enumand@boxtraits (refactor test factories).Also, added a string shape with the
@enumtrait for the 2.0 enum roundtrip test case.Updated removing unnecessary defaults to fix
MemberShapecases with comments to explain each case.Testing:
Ran
./gradlew clean build check.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.