Revert "Defer projection failure until after plugins run (#1416)" #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
approved these changes
Sep 28, 2022
milesziemer
approved these changes
Sep 28, 2022
syall
approved these changes
Sep 28, 2022
milesziemer
added a commit
to milesziemer/smithy
that referenced
this pull request
Sep 29, 2022
…thy-lang#1416)" (smithy-lang#1429)" This reverts commit 18676ec.
milesziemer
added a commit
to milesziemer/smithy
that referenced
this pull request
May 4, 2023
This changes `SmithyBuildImpl` to continue applying plugins after one fails, throwing the error (if present) after they have all completed. This is useful for example when you want to see the serialized output of a model you know is valid but a plugin is causing the whole build to fail. A new test case was added to ensure that artifacts produced by valid plugins are still created despite the build failing. This was originally implemented in smithy-lang#1416, but was rolled back in smithy-lang#1429 as a precaution since we had an unrelated issue ocurring at the time.
milesziemer
added a commit
that referenced
this pull request
May 4, 2023
This changes `SmithyBuildImpl` to continue applying plugins after one fails, throwing the error (if present) after they have all completed. This is useful for example when you want to see the serialized output of a model you know is valid but a plugin is causing the whole build to fail. A new test case was added to ensure that artifacts produced by valid plugins are still created despite the build failing. This was originally implemented in #1416, but was rolled back in #1429 as a precaution since we had an unrelated issue ocurring at the time.
syall
pushed a commit
to Xtansia/smithy
that referenced
this pull request
Aug 11, 2023
This changes `SmithyBuildImpl` to continue applying plugins after one fails, throwing the error (if present) after they have all completed. This is useful for example when you want to see the serialized output of a model you know is valid but a plugin is causing the whole build to fail. A new test case was added to ensure that artifacts produced by valid plugins are still created despite the build failing. This was originally implemented in smithy-lang#1416, but was rolled back in smithy-lang#1429 as a precaution since we had an unrelated issue ocurring at the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit #1416.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.