Reverse the logic of the protocol test to be in sync with the current… #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ists Currently both aws query and ec2 query do serialize empty lists
sugmanue
force-pushed
the
empty-lists-are-serialized-protocol-test
branch
from
f47b9f3 to
502258a
Compare
kuhe
approved these changes
Oct 12, 2022
kstich
approved these changes
Oct 28, 2022
syall
pushed a commit
to syall/aws-sdk-go-v2
that referenced
this pull request
Nov 11, 2022
Update serializing empty lists for query protocols (see references)
to pass protocol tests.
Previous Behavior:
`{ "ListArg": [] }` serializes to ``.
Current Behavior:
`{ "ListArg": [] }` serializes to `?ListArg=`.
References:
- smithy-lang/smithy#1444
- [AWS query
protocol](https://awslabs.github.io/smithy/2.0/aws/protocols/aws-query-protocol.html)
- [AWS EC2 query
protocol](https://awslabs.github.io/smithy/2.0/aws/protocols/aws-ec2-query-protocol.html)
syall
pushed a commit
to syall/aws-sdk-go-v2
that referenced
this pull request
Nov 11, 2022
Update serializing empty lists for query protocols (see references)
to pass protocol tests.
Previous Behavior:
`{ "ListArg": [] }` serializes to ``.
Current Behavior:
`{ "ListArg": [] }` serializes to `?ListArg=`.
References:
- smithy-lang/smithy#1444
- [AWS query
protocol](https://awslabs.github.io/smithy/2.0/aws/protocols/aws-query-protocol.html)
- [AWS EC2 query
protocol](https://awslabs.github.io/smithy/2.0/aws/protocols/aws-ec2-query-protocol.html)
syall
pushed a commit
to syall/aws-sdk-go-v2
that referenced
this pull request
Nov 11, 2022
Update serializing empty lists for query protocols (see references)
to pass protocol tests.
Previous Behavior:
`{ "ListArg": [] }` serializes to ``.
Current Behavior:
`{ "ListArg": [] }` serializes to `?ListArg=`.
References:
- smithy-lang/smithy#1444
- [AWS query
protocol](https://awslabs.github.io/smithy/2.0/aws/protocols/aws-query-protocol.html)
- [AWS EC2 query
protocol](https://awslabs.github.io/smithy/2.0/aws/protocols/aws-ec2-query-protocol.html)
syall
pushed a commit
to syall/aws-sdk-go-v2
that referenced
this pull request
Nov 11, 2022
Update serializing empty lists for query protocols (see references)
to pass protocol tests.
Previous Behavior:
`{ "ListArg": [] }` serializes to ``.
Current Behavior:
`{ "ListArg": [] }` serializes to `?ListArg=`.
References:
- smithy-lang/smithy#1444
- [AWS query
protocol](https://awslabs.github.io/smithy/2.0/aws/protocols/aws-query-protocol.html)
- [AWS EC2 query
protocol](https://awslabs.github.io/smithy/2.0/aws/protocols/aws-ec2-query-protocol.html)
syall
pushed a commit
to syall/aws-sdk-go-v2
that referenced
this pull request
Jan 28, 2023
Update serializing empty lists for query protocols (see references)
to pass protocol tests.
Previous Behavior:
`{ "ListArg": [] }` serializes to ``.
Current Behavior:
`{ "ListArg": [] }` serializes to `?ListArg=`.
References:
- smithy-lang/smithy#1444
- [AWS query
protocol](https://awslabs.github.io/smithy/2.0/aws/protocols/aws-query-protocol.html)
- [AWS EC2 query
protocol](https://awslabs.github.io/smithy/2.0/aws/protocols/aws-ec2-query-protocol.html)
syall
pushed a commit
to syall/aws-sdk-go-v2
that referenced
this pull request
Jan 30, 2023
Update serializing empty lists for query protocols (see references)
to pass protocol tests.
Previous Behavior:
`{ "ListArg": [] }` serializes to ``.
Current Behavior:
`{ "ListArg": [] }` serializes to `?ListArg=`.
References:
- smithy-lang/smithy#1444
- [AWS query
protocol](https://awslabs.github.io/smithy/2.0/aws/protocols/aws-query-protocol.html)
- [AWS EC2 query
protocol](https://awslabs.github.io/smithy/2.0/aws/protocols/aws-ec2-query-protocol.html)
syall
pushed a commit
to syall/aws-sdk-go-v2
that referenced
this pull request
Jan 31, 2023
Update serializing empty lists for query protocols (see references)
to pass protocol tests.
Previous Behavior:
`{ "ListArg": [] }` serializes to ``.
Current Behavior:
`{ "ListArg": [] }` serializes to `?ListArg=`.
References:
- smithy-lang/smithy#1444
- [AWS query
protocol](https://awslabs.github.io/smithy/2.0/aws/protocols/aws-query-protocol.html)
- [AWS EC2 query
protocol](https://awslabs.github.io/smithy/2.0/aws/protocols/aws-ec2-query-protocol.html)
syall
pushed a commit
to syall/aws-sdk-go-v2
that referenced
this pull request
Jan 31, 2023
Update serializing empty lists for query protocols (see references)
to pass protocol tests.
Previous Behavior:
`{ "ListArg": [] }` serializes to ``.
Current Behavior:
`{ "ListArg": [] }` serializes to `?ListArg=`.
References:
- smithy-lang/smithy#1444
- [AWS query
protocol](https://awslabs.github.io/smithy/2.0/aws/protocols/aws-query-protocol.html)
- [AWS EC2 query
protocol](https://awslabs.github.io/smithy/2.0/aws/protocols/aws-ec2-query-protocol.html)
alextwoods
added a commit
to alextwoods/aws-sdk-ruby-v4
that referenced
this pull request
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… behavior
Issue #, if available:
Description of changes:
This change reverses the logic of the protocol test that asserts that we do not serialize empty lists. We currently do it for other SDK and some services rely on this behavior.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.