Fix grammar for MapMembers #1520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MapMembers grammar was incorrectly stating a BR was required between the key and value, but actually WS is required. This was already reflected in the implementation, and the previous grammar was at odds with being able to use a comma to separate the key and value members. I added a new test case for 2.0 models and map parsing. Closes #1511
sugmanue
approved these changes
Dec 1, 2022
|
Hey @mtdowling I think I've found a second instance where a BR should be a ValueAssignment = thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MapMembers grammar was incorrectly stating a BR was required between the key and value, but actually WS is required. This was already reflected in the implementation, and the previous grammar was at odds with being able to use a comma to separate the key and value members. I added a new test case for 2.0 models and map parsing.
Closes #1511
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.