Ensure that the event listener gets all the events #1698
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently not all events are passed to the listener given the way this is implemented, e.g., if some part of logic add a set of events directly to the list using
addAll
. In particularLoaderShapeMap
adds all the events to the events list for eachShapeModifier
here which are then not shown in the output. Validation for the following modelWill currently output
After this change it will output
This example shows that we should probably create an abstraction to contains the
ValidationEvents
instead of just using a rawList
.EDIT
After the recent change made by Michael this error show up in the output since now the validation events are processed in a different way, however we're still not sending those to the listener, so I think is still worth patching.