Use pretty validation output with smithy diff #1710
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smithy diff now uses the pretty validation output. The old and new models are both validated, but only build-failing errors are shown. When the original model fails, a label is added before ERROR/DANGER to show it's on the OLD model. When the new model fails, it shows a NEW label. When running the diff with two valid models, events have a label of DIFF. The events shown here use the --severity option and default to WARNING when not set.
mtdowling
force-pushed
the
use-pretty-output-with-diff
branch
from
434a974 to
dcd7a75
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Replaced with #1712 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smithy diff now uses the pretty validation output.
The old and new models are both validated, but only build-failing errors are shown. When the original model fails, a label is added before ERROR/DANGER to show it's on the OLD model. When the new model fails, it shows a NEW label.
When running the diff with two valid models, events have a label of DIFF. The events shown here use the --severity option and default to WARNING when not set.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.