Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate resource shape 'properties' with Smithy IDL serialization #1996

Merged
merged 4 commits into from
Oct 11, 2023

Conversation

zourzouvillys
Copy link
Contributor

Adds support for outputting properties for resources in the Smithy IDL model serializer.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zourzouvillys zourzouvillys requested a review from a team as a code owner September 30, 2023 23:28
@kstich
Copy link
Contributor

kstich commented Oct 3, 2023

Thanks for catching this! If you'd like to take it to completion, can you add some valid resource properties to this test file? We can add the test cases if you'd prefer, just let us know.

adding properties to MyResource triggered validation errors, so had to extend test schema to pass validation.
@zourzouvillys
Copy link
Contributor Author

added.

upon modifying the service-shapes.smithy file to just include properties within MyResource without adding new operations, i encountered validation failures unrelated to this specific change that look like they should have been getting triggered and weren't. adding the properties results in validation (correctly?) failing because the id was not @required.

if i'm not missing something here, happy to investigate separately from this PR, and/or open an issue.

@kstich kstich merged commit e5cd7d1 into smithy-lang:main Oct 11, 2023
10 checks passed
@zourzouvillys zourzouvillys deleted the idl-properties-serialization branch October 12, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants