Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for ExampleTrait.Example equality #2009

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Conversation

lewisjkl
Copy link
Contributor

Description of changes:

Found this issue through:

val modelString =
  """|$version: "2"
     |
     |namespace foo
     |
     |@examples([
     |  {
     |    title: "Test This"
     |    input: {
     |      test: "something"
     |    }
     |  }
     |])
     |operation Foo {
     |  input := {
     |    test: String
     |  }
     |}
     |""".stripMargin

val one = Model
  .assembler()
  .addUnparsedModel("foo.smithy", modelString)
  .assemble()
  .unwrap()
val two = Model
  .assembler()
  .addUnparsedModel("foo.smithy", modelString)
  .assemble()
  .unwrap()

one == two // false

I've allowed edits from maintainers, feel free to change as you see fit or tell me what to change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

YES

@lewisjkl lewisjkl requested a review from a team as a code owner October 12, 2023 18:44
@lewisjkl
Copy link
Contributor Author

Sorry for the noise, I should have checked prior to pushing rather than assume there wouldn't be more issues.. This time, ./gradlew :smithy-model:checkstyleMain succeeded locally with no issues.

@mtdowling mtdowling merged commit c752eac into smithy-lang:main Oct 26, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants