Add aws.iam#iamAction trait
#2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
commented
Nov 8, 2023
There was a problem hiding this comment.
hpmellema
reviewed
Nov 8, 2023
...urces/software/amazon/smithy/aws/iam/traits/errorfiles/iam-action-resource-detachment.errors
Outdated
Show resolved
Hide resolved
hpmellema
reviewed
Nov 8, 2023
smithy-aws-iam-traits/src/main/resources/META-INF/smithy/aws.iam.smithy
Outdated
Show resolved
Hide resolved
kstich
force-pushed
the
add_iamAction_trait
branch
from
6cdae7f to
11c00cb
Compare
hpmellema
reviewed
Nov 8, 2023
hpmellema
reviewed
Nov 8, 2023
This commit introduces the iamAction trait to both consolidate and enhance the customization for IAM actions in derived from Smithy operations. It deprecates the actionName, actionPermissionDescription, and requiredAction traits - placing their behavior in the name, documentation, and requiredAction members respectively. A relativeDocumentation member is new, allowing for linking to docs within IAM documentation. A createsResources member is new, allowing for the explicit listing of resources that performing an IAM action will create. A resources member is new, allowing for the override configuration of required and optional resources that an IAM action can be authorized against (including the condition keys that can be used). This enables the detachment of an IAM action from being required to authorize against its resource hierarchy for special cases. The specification is also reorganized into sections for traits affecting resources, actions, and condition keys for easier navigation.
kstich
force-pushed
the
add_iamAction_trait
branch
from
11c00cb to
55c81b8
Compare
hpmellema
approved these changes
Nov 8, 2023
haydenbaker
added a commit
that referenced
this pull request
Nov 8, 2023
haydenbaker
added a commit
that referenced
this pull request
Nov 8, 2023
haydenbaker
added a commit
that referenced
this pull request
Nov 9, 2023
* Bump version to 1.41.0 * Add entry for #2034 * Remove 'therefore' Co-authored-by: Hunter Mellema <124718352+hpmellema@users.noreply.github.com> * Add 'plugin' Co-authored-by: Hunter Mellema <124718352+hpmellema@users.noreply.github.com> * Add entry for #2036 --------- Co-authored-by: Hunter Mellema <124718352+hpmellema@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the
iamActiontrait to both consolidate and enhance the customization for IAM actions in derived from Smithy operations. It deprecates theactionName,actionPermissionDescription, andrequiredActiontraits - placing their behavior in thename,documentation, andrequiredActionmembers respectively.A
relativeDocumentationmember is new, allowing for linking to docs within IAM documentation.A
createsResourcesmember is new, allowing for the explicit listing of resources that performing an IAM action will create.A
resourcesmember is new, allowing for the override configuration of required and optional resources that an IAM action can be authorized against (including the condition keys that can be used). This enables the detachment of an IAM action from being required to authorize against its resource hierarchy for special cases.The specification is also reorganized into sections for traits affecting resources, actions, and condition keys for easier navigation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.