Expand default value protocol tests #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds to existing json1_0 protocol tests for default values to include members with 0 default values - ie. empty string, 0, false. Also has an additional case for when _the_ default value is explicitly provided in parameters, it should not be ignored. A case was also added for members that are clientOptional.
milesziemer
force-pushed
the
update-default-value-protocl-tests
branch
from
7e6bd77 to
b077dba
Compare
4 tasks
mtdowling
approved these changes
Jan 24, 2024
hpmellema
pushed a commit
to hpmellema/smithy
that referenced
this pull request
Jan 25, 2024
Adds to existing json1_0 protocol tests for default values to include members with 0 default values - ie. empty string, 0, false. Also has an additional case for when _the_ default value is explicitly provided in parameters, it should not be ignored. A case was also added for members that are clientOptional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds to existing json1_0 protocol tests for default values to include members with 0 default values - ie. empty string, 0, false. Also has an additional case for when the default value is explicitly provided in parameters, it should not be ignored. A case was also added for members that are clientOptional.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.