Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JReleaser config #2059

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

milesziemer
Copy link
Contributor

Adds the jreleaser plugin and configuration for publishing to Maven Central. Using the plugin is configurable with a Gradle property, so we can continue to use the old release method if necessary. The closeRepository and releaseRepository props in the jreleaser config are set to false right now so we can check the staged artifacts before actually releasing, but can be changed later to automatically release.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Adds the jreleaser plugin and configuration for publishing to
Maven Central. Using the plugin is configurable with a Gradle
property, so we can continue to use the old release method if
necessary. The `closeRepository` and `releaseRepository` props
in the jreleaser config are set to false right now so we can
check the staged artifacts before actually releasing, but can
be changed later to automatically release.
@milesziemer milesziemer requested a review from a team as a code owner December 4, 2023 15:59
@@ -24,7 +24,8 @@ plugins {
id "com.github.spotbugs" version "4.7.1"
id "io.codearte.nexus-staging" version "0.30.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get rid of this too right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I left it in so we could fall back to it if necessary

@milesziemer milesziemer merged commit a0e0eab into smithy-lang:main Dec 12, 2023
10 checks passed
rchache pushed a commit to rchache/smithy that referenced this pull request Jan 2, 2024
Adds the jreleaser plugin and configuration for publishing to
Maven Central. Using the plugin is configurable with a Gradle
property, so we can continue to use the old release method if
necessary. The `closeRepository` and `releaseRepository` props
in the jreleaser config are set to false right now so we can
check the staged artifacts before actually releasing, but can
be changed later to automatically release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants