Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting erroneous outer tags #2071

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Correcting erroneous outer tags #2071

merged 1 commit into from
Dec 13, 2023

Conversation

frij-aws
Copy link
Contributor

Issue #, if available:
The ABAP codegen strictly tests XML using XSLT which makes it sensitive to incorrect outer tags. We stumbled on these errors in the protocol tests, introduced in a recent commit.

Description of changes:
Correcting the outer tags in three protocol tests. These have been tested against the ABAP codegen.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@frij-aws frij-aws requested a review from a team as a code owner December 12, 2023 22:28
@frij-aws frij-aws requested a review from hpmellema December 12, 2023 22:28
@kstich kstich merged commit 5a2a5ea into smithy-lang:main Dec 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants