Remove service renames after flattenNamespaces #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
approved these changes
Jan 23, 2024
flattenNamespaces applies all service renames to disambiguate shapes that could be in conflict after flattening. But when consumers try to reload the transformed model, they get an error like: ``` "Service rename for `foo` does not actually change the name from `bar`" ``` because the rename has already been applied. This commit changes FlattenTransformer to also update the service shape by removing all renames, so consumers of a flattened model don't run into validation issues.
milesziemer
force-pushed
the
fix-service-renames-in-flatten-transformer
branch
from
77d9c3f to
47ca575
Compare
haydenbaker
approved these changes
Jan 23, 2024
hpmellema
pushed a commit
to hpmellema/smithy
that referenced
this pull request
Jan 25, 2024
flattenNamespaces applies all service renames to disambiguate shapes that could be in conflict after flattening. But when consumers try to reload the transformed model, they get an error like: ``` "Service rename for `foo` does not actually change the name from `bar`" ``` because the rename has already been applied. This commit changes FlattenTransformer to also update the service shape by removing all renames, so consumers of a flattened model don't run into validation issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flattenNamespaces applies all service renames to disambiguate shapes that could be in conflict after flattening. But when consumers try to reload the transformed model, they get an error like:
because the rename has already been applied. This commit changes FlattenTransformer to also update the service shape by removing all renames, so consumers of a flattened model don't run into validation issues.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.