Fix text block incidental whitespace handling #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
force-pushed
the
fix-text-block-parsing-and-formatting
branch
from
895dfa3 to
c327f51
Compare
haydenbaker
approved these changes
Feb 16, 2024
hpmellema
approved these changes
Feb 16, 2024
This commit fixes the handling of incidental whitespace on the last line of a text block when parsing, and fixes the formatting of text blocks so that indentation and non-incidental whitespace isn't removed. There was a bug in parsing the last line of text blocks that needed to be fixed, and then the formatter needed special handling for serializing text blocks. Closes #2141
mtdowling
force-pushed
the
fix-text-block-parsing-and-formatting
branch
from
c327f51 to
40855c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the handling of incidental whitespace on the last line of a text block when parsing, and fixes the formatting of text blocks so that indentation and non-incidental whitespace isn't removed.
There was a bug in parsing the last line of text blocks that needed to be fixed, and then the formatter needed special handling for serializing text blocks.
Closes #2141
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.