Fix member mixin lists #2157
Merged
Fix member mixin lists #2157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where a member that sources traits from multiple mixins would have all but the last of those mixins dropped from its list, *if* it also happened to apply new traits locally.
Shape builders have a saftey feature to fix members whose mixin list doesn't match the expected list based on the container's mixin list. This fixes a bug in that where it would drop all but the last mixin from that "fixed" list.
syall
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
What do these changes do?
Fixes two bugs regarding member shapes that have multiple mixins:
Why are they important?
Correctness is a virtue.
Testing
How did you test these changes?
The specific customer case was tested manually, unit tests derived from that were added.
Links
Links to additional context, if necessary
Issue #, if applicable (see here for a list of keywords to use for linking issues)
Fixes Loading via Smithy and Json produces different result #2150
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.