Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add data-shape-only visitor class #2168

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Add data-shape-only visitor class #2168

merged 1 commit into from
Feb 28, 2024

Conversation

hpmellema
Copy link
Contributor

Background

  • While working on trait codegen (see: Trait code generation #2074) I have encountered quite a few cases where generators need to visit all data shapes types, but should fail on service shapes (resource, operation, service). This PR adds a new abstract class to provide this behavior as a common abstract class.

Testing

  • N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hpmellema hpmellema requested a review from a team as a code owner February 28, 2024 16:49
@hpmellema hpmellema requested a review from kstich February 28, 2024 16:49
@hpmellema hpmellema force-pushed the data-shape-only-visitor branch from 0d063dc to d781ea2 Compare February 28, 2024 18:43
@hpmellema hpmellema merged commit e9cca36 into smithy-lang:main Feb 28, 2024
10 checks passed
@hpmellema hpmellema deleted the data-shape-only-visitor branch February 28, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordonPhillips JordonPhillips JordonPhillips approved these changes

@kstich kstich Awaiting requested review from kstich kstich is a code owner automatically assigned from smithy-lang/smithy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hpmellema @JordonPhillips