Support deprecated on fields in the OpenAPI conversion
#2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might need a bit of guidance on this one. At 66b3462 I'm setting the deprecated field for json schema for what I think are member fields. This seems to break cloudformation tests in CfnSchemasTest, how can this be separated? |
|
CloudFormation uses Draft 7, so those tests should pass when this field is not being added for that JSON Schema version. |
|
@kstich thanks, I made some changes, including only setting it when the json schema version != DRAFT07, which I assume will work meaning set it if version is "greater" than DRAFT07. |
kstich
requested changes
Apr 10, 2024
smithy-jsonschema/src/main/java/software/amazon/smithy/jsonschema/JsonSchemaShapeVisitor.java
Outdated
Show resolved
Hide resolved
...api/src/test/java/software/amazon/smithy/openapi/fromsmithy/OpenApiJsonSchemaMapperTest.java
Outdated
Show resolved
Hide resolved
smithy-jsonschema/src/test/java/software/amazon/smithy/jsonschema/JsonSchemaConverterTest.java
Show resolved
Hide resolved
kstich
reviewed
Apr 11, 2024
smithy-jsonschema/src/test/java/software/amazon/smithy/jsonschema/JsonSchemaConverterTest.java
Outdated
Show resolved
Hide resolved
smithy-jsonschema/src/test/java/software/amazon/smithy/jsonschema/JsonSchemaConverterTest.java
Outdated
Show resolved
Hide resolved
smithy-jsonschema/src/test/java/software/amazon/smithy/jsonschema/JsonSchemaConverterTest.java
Outdated
Show resolved
Hide resolved
smithy-jsonschema/src/test/java/software/amazon/smithy/jsonschema/JsonSchemaConverterTest.java
Outdated
Show resolved
Hide resolved
kstich
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
It seems that the OpenAPI transformation doesn't set
deprecated: truefor members that are annotated as@deprecated(...).Started by just adding a failing test to check that it makes sense. If this is something that is not expected I will proceed to try a fix.