Add support for default trait on members #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpmellema
requested review from
kstich and
haydenbaker
and removed request for
kstich and
AndrewFossAWS
haydenbaker
reviewed
May 1, 2024
...y-trait-codegen/src/it/java/software/amazon/smithy/traitcodegen/test/LoadsFromModelTest.java
Show resolved
Hide resolved
haydenbaker
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Adds support for defaults on trait member values.
Applying the
@defaulttrait to a member will cause it to be treated as non-nullable and will set the value as the initial value for the member within the shape's builder.Testing
A new set of integration tests were added to ensure the defaults for all types of members are set on a structure shape with no value for those default members.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.