Servers must reject {}
when deserializing a union
#2300
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once we're inside of a
{}
JSON object, a known union variant must beprovided. Servers must not accept
{}
as "the union shape was not set"when the union shape is optional (which was the behavior in smithy-rs
prior to smithy-lang/smithy-rs#3481).
This commit adds a protocol test to pin this behavior.
Testing
I verified that the added test fails in smithy-rs when checking out a commit
prior to smithy-lang/smithy-rs#3481
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.