Add protocol test for when content-type must be set but no headers are sent #2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e sent The suite already contains a test with ID `RestJsonWithBodyExpectsApplicationJsonContentType` for when `Content-Type: aplication/json` is expected by the server but the client sends a wrong value for the header. However, there is no test testing the case where the client sends no headers. This commit adds such a test.
kstich
requested changes
Jun 6, 2024
smithy-aws-protocol-tests/model/restJson1/malformedRequests/malformed-content-type.smithy
Outdated
Show resolved
Hide resolved
…lformed-content-type.smithy Co-authored-by: Kevin Stich <kevin@kstich.com>
kstich
approved these changes
Jun 6, 2024
david-perez
deleted the
davidpz/rest-json-with-body-expects-application-json-content-type-no-headers
branch
david-perez
added a commit
to david-perez/smithy
that referenced
this pull request
Jun 7, 2024
Initial motivation for this stems off smithy-lang#2310, but for when the input is `@httpPayload`-bound. It's important that we test `Content-Type` specifically with `@httpPayload` operations, because the header can be checked without having to inspect the body, and because the spec has special provisions (https://smithy.io/2.0/aws/protocols/aws-restjson1-protocol.html#content-type). There were no protocol tests exercising `Content-Type` when the input is `@httpPayload`-bound: - In the case of blobs, servers must accept any (test already exists) and no `Content-Type` (test added in this commit). - In other cases, there were protocol tests for `union` and `structure` shapes. I've added an operation with an `@httpPayload`-bound string shape. Note that `document` shapes remain untested.
JordonPhillips
pushed a commit
that referenced
this pull request
Jun 17, 2024
Initial motivation for this stems off #2310, but for when the input is `@httpPayload`-bound. It's important that we test `Content-Type` specifically with `@httpPayload` operations, because the header can be checked without having to inspect the body, and because the spec has special provisions (https://smithy.io/2.0/aws/protocols/aws-restjson1-protocol.html#content-type). There were no protocol tests exercising `Content-Type` when the input is `@httpPayload`-bound: - In the case of blobs, servers must accept any (test already exists) and no `Content-Type` (test added in this commit). - In other cases, there were protocol tests for `union` and `structure` shapes. I've added an operation with an `@httpPayload`-bound string shape. Note that `document` shapes remain untested.
1 task
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suite already contains a test with ID
RestJsonWithBodyExpectsApplicationJsonContentTypefor whenContent-Type: aplication/jsonis expected by the server but the client sends a wrong valuefor the header. However, there is no test testing the case where the client
sends no headers. This commit adds such a test.
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.