Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix body of RpcV2CborClientPopulatesDefaultValuesInInput protocol test #2320

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

alextwoods
Copy link
Contributor

Background

The previous body did not include the top level "default" member and decoded to:

{
  "defaultString"=>"hi", 
  "defaultBoolean"=>true, 
  "defaultList"=>[],
  # ect....
}

This adds in the top level "default" so the new body decodes as:

{
  "defaults"=>{
    "defaultString"=>"hi", 
    "defaultBoolean"=>true, 
    "defaultList"=>[],
    # ect...
  }
}

Testing

  • Tested with smithy-ruby RPCV2 implementation.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alextwoods alextwoods requested a review from a team as a code owner June 12, 2024 17:07
@kstich kstich requested review from kstich and removed request for hpmellema June 12, 2024 17:22
@kstich kstich merged commit cd364e4 into smithy-lang:main Jun 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants