Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Protocol Tests #359

Merged
merged 5 commits into from
Apr 3, 2020
Merged

Update Protocol Tests #359

merged 5 commits into from
Apr 3, 2020

Conversation

kstich
Copy link
Contributor

@kstich kstich commented Apr 3, 2020

This is a reapplication of fixes in the following PRs from master:

#321
#333
#335
#349


Fixes several issues with EC2-Query tests

  • Adds an aws.api#service trait, sdkId="EC2 Protocol"
  • Uses correct Idempotency token property names
  • Uses correct Idempotency token test Action names
  • Fixes auto-generated idempotency token value
  • Fixes list member name capitalization
  • Adds missing "/" to a closing XML element

Fixes several issues with the JSON-RPC-1.1 tests

  • Fixes service name in several x-amz-target headers
  • Fixes an operation name in x-amz-target header
  • Removes errant required header when not supplied
  • Fixes several [] vs {} discrepancies for empty structures
  • Adds missing body for operation that has a response

Fixes several issues with the Query tests

  • Adds an aws.api#service trait, sdkId="Query Protocol"
  • Fixes several test Action names
  • Fixes auto-generated idempotency token value
  • Fixes several map/list entry and value counter issues
  • Fixes discrepancies with map list member serialized keys
  • Adds missing "/" to a closing XML element
  • Fixes several xmlName trait discrepancies
  • Fixes several result wrapper shape names

Fixes several issues with the Rest-JSON tests

  • Adds an aws.api#service trait, sdkId="Rest Json Protocol"
  • Fixes several uri discrepancies
  • Fixes missing x-amzn-errortype header
  • Fixes several header name and value discrepancies
  • Fixes several issues where a member indicating a dateTime was
    using a shape of the incorrect format
  • Fixes auto-generated idempotency token value
  • Fix requiring a param when no content can set it
  • Fixes several jsonName trait discrepancies
  • Removes header serialized values from bodies
  • Fixes issues with label encoding
  • Updates NullAndEmptyHeaders tests

Fixes several issues with the Rest-XML tests

  • Adds an aws.api#service trait, sdkId="Rest Xml Protocol"
  • Fixes several uri discrepancies
  • Adds missing "/" to a closing XML element
  • Fixes several xmlName trait discrepancies
  • Fixes several request root element names
  • Fixes several header name and value discrepancies
  • Fixes several issues where a member indicating a dateTime was
    using a shape of the incorrect format
  • Adds missing ":" to serialized namespace uris
  • Fixes auto-generated idempotency token value
  • Fixes incorrect default timestamp serialization format
  • Fixes issues with label encoding
  • Updates NullAndEmptyHeaders tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

kstich added 5 commits April 3, 2020 12:02
* Adds an aws.api#service trait, sdkId="EC2 Protocol"
* Uses correct Idempotency token property names
* Uses correct Idempotency token test Action names
* Fixes auto-generated idempotency token value
* Fixes list member name capitalization
* Adds missing "/" to a closing XML element
* Fix issue with b64 encoding blobs
* Fixes service name in several x-amz-target headers
* Fixes an operation name in x-amz-target header
* Removes errant required header when not supplied
* Fixes several [] vs {} discrepancies for empty structures
* Adds missing body for operation that has a response
* Adds an aws.api#service trait, sdkId="Query Protocol"
* Fixes several test Action names
* Fixes auto-generated idempotency token value
* Fixes several map/list entry and value counter issues
* Fixes discrepancies with map list member serialized keys
* Adds missing "/" to a closing XML element
* Fixes several xmlName trait discrepancies
* Fixes several result wrapper shape names
* Adds an aws.api#service trait, sdkId="Rest Json Protocol"
* Fixes several uri discrepancies
* Fixes missing x-amzn-errortype header
* Fixes several header name and value discrepancies
* Fixes several issues where a member indicating a dateTime was
  using a shape of the incorrect format
* Fixes auto-generated idempotency token value
* Fix requiring a param when no content can set it
* Fixes several jsonName trait discrepancies
* Removes header serialized values from bodies
* Fixes issues with label encoding
* Updates NullAndEmptyHeaders tests
* Adds an aws.api#service trait, sdkId="Rest Xml Protocol"
* Fixes several uri discrepancies
* Adds missing "/" to a closing XML element
* Fixes several xmlName trait discrepancies
* Fixes several request root element names
* Fixes several header name and value discrepancies
* Fixes several issues where a member indicating a dateTime was
  using a shape of the incorrect format
* Adds missing ":" to serialized namespace uris
* Fixes auto-generated idempotency token value
* Fixes incorrect default timestamp serialization format
* Fixes issues with label encoding
* Updates NullAndEmptyHeaders tests
@kstich kstich requested a review from mtdowling April 3, 2020 19:55
@kstich kstich merged commit d9c3667 into 0.10 Apr 3, 2020
@kstich kstich deleted the protocol_test_reapply branch April 3, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants