Update opinionated protocol tests to not describe optional behavior #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
reviewed
Jul 5, 2020
smithy-aws-protocol-tests/model/restJson1/empty-input-output.smithy
Outdated
Show resolved
Hide resolved
smithy-aws-protocol-tests/model/restJson1/empty-input-output.smithy
Outdated
Show resolved
Hide resolved
Removes the protocol tests for HTTP Prefix Header deserialization, deserializing to an empty map vs null value. Null vs empty map will be SDK implementation specific distinction. If there was a way to model `empty` as an expectation that would encompass both null and empty but initialized map this test would be more portable. Updates the empty input output serialization protocol test to expect empty payload not empty JSON object as the serialized result. It doesn't look like the REST-JSON protocol should be serializing empty JSON object when no members are serialized.
jasdel
force-pushed
the
fixup/RestJSONProtoTest
branch
from
381e956 to
254f730
Compare
mtdowling
approved these changes
Jul 6, 2020
kggilmer
pushed a commit
to kggilmer/smithy
that referenced
this pull request
Jul 14, 2020
…mithy-lang#481) * Update opinionated protocol tests to not describe optional behavior Removes the protocol tests for HTTP Prefix Header deserialization, deserializing to an empty map vs null value. Null vs empty map will be SDK implementation specific distinction. If there was a way to model `empty` as an expectation that would encompass both null and empty but initialized map this test would be more portable. Updates the empty input output serialization protocol test to expect empty payload not empty JSON object as the serialized result. It doesn't look like the REST-JSON protocol should be serializing empty JSON object when no members are serialized.
et22
pushed a commit
to et22/smithy
that referenced
this pull request
Jul 21, 2020
…mithy-lang#481) * Update opinionated protocol tests to not describe optional behavior Removes the protocol tests for HTTP Prefix Header deserialization, deserializing to an empty map vs null value. Null vs empty map will be SDK implementation specific distinction. If there was a way to model `empty` as an expectation that would encompass both null and empty but initialized map this test would be more portable. Updates the empty input output serialization protocol test to expect empty payload not empty JSON object as the serialized result. It doesn't look like the REST-JSON protocol should be serializing empty JSON object when no members are serialized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the protocol tests for HTTP Prefix Header deserialization, deserializing to an empty map vs null value. Null vs empty map will be SDK implementation specific distinction. If there was a way to model
emptyas an expectation that would encompass both null and empty but initialized map this test would be more portable.Updates the empty input output serialization protocol test to expect empty payload not empty JSON object as the serialized result. It doesn't look like the REST-JSON protocol should be serializing empty JSON object when no members are serialized.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.