Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] capabilities call ended up within nullpointer exception #1

Conversation

boesing
Copy link
Collaborator

@boesing boesing commented Aug 27, 2018

I've created a patch to fix the current nullpointer exception.

I've expirienced this issue by using the adapter with zend-cache v2.8 and its SimpleCacheDecorator.

The __construct of that decorator uses StorageAdapterInterface::getCapabilities to check some stuff regarding PSR.

I've modified the composer.json to drop support of PHP 5.3, which reached its EOL 4 years ago...
I've added the min PHP Version 5.5, since I'd like to use ::class constant to provide proper FQCN.

However, I've dropped some direct property accesses of resourceManager and created a new private method RedisArray::getRedisResourceManager to handle those direct property usages.

I would appreciate, if you merge this PR and create a new Version v1.1.0.

Thanks in advance.

@smoke
Copy link
Owner

smoke commented Aug 28, 2018

@boesing You did good job and I like it!
However given I no longer use this package it would be difficult for me to maintain it actively, so would you like to add you as collaborator, so you can do it?

@boesing
Copy link
Collaborator Author

boesing commented Aug 28, 2018

@smoke ofc. I gonna start work on zend-cache and would like to migrate this package into the zend organisation if thats okay for you.

@smoke
Copy link
Owner

smoke commented Aug 28, 2018

I welcome this initiative, let me know how to help!

@smoke
Copy link
Owner

smoke commented Aug 28, 2018

@boesing I have added you as collabor in this repo and also as maintainer in https://packagist.org/packages/smoke/zf2-cache-storage-redis-array

I grant you permissions to do as you wish with this package, repo and the code related as long as this is something the community would benefit, your actions are transparent and you will do no harm to anyone and anything with that work!

@boesing
Copy link
Collaborator Author

boesing commented Aug 28, 2018

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants