No longer unwrap sending the connection opening result #2831
Annotations
15 warnings
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy@master. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
lib/src/libp2p/connection/noise.rs#L303
warning: this `else { if .. }` block can be collapsed
--> lib/src/libp2p/connection/noise.rs:303:20
|
303 | } else {
| ____________________^
304 | | if let Ok(Some(next_frame_length)) =
305 | | outer_read_write.incoming_bytes_take_array::<2>()
306 | | {
... |
310 | | }
311 | | }
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if
= note: `#[warn(clippy::collapsible_else_if)]` on by default
help: collapse nested if block
|
303 ~ } else if let Ok(Some(next_frame_length)) =
304 + outer_read_write.incoming_bytes_take_array::<2>()
305 + {
306 + self.next_in_message_size = Some(u16::from_be_bytes(next_frame_length));
307 + } else {
308 + break;
309 + }
|
|
lib/src/libp2p/connection/noise.rs#L303
warning: this `else { if .. }` block can be collapsed
--> lib/src/libp2p/connection/noise.rs:303:20
|
303 | } else {
| ____________________^
304 | | if let Ok(Some(next_frame_length)) =
305 | | outer_read_write.incoming_bytes_take_array::<2>()
306 | | {
... |
310 | | }
311 | | }
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if
= note: `#[warn(clippy::collapsible_else_if)]` on by default
help: collapse nested if block
|
303 ~ } else if let Ok(Some(next_frame_length)) =
304 + outer_read_write.incoming_bytes_take_array::<2>()
305 + {
306 + self.next_in_message_size = Some(u16::from_be_bytes(next_frame_length));
307 + } else {
308 + break;
309 + }
|
|
lib/src/executor/host.rs#L2401
warning: unneeded `return` statement
--> lib/src/executor/host.rs:2401:17
|
2401 | / return self.inner.alloc_write_and_return_pointer_size(
2402 | | host_fn.name(),
2403 | | if let Some(outcome) = outcome {
2404 | | either::Left(
... |
2410 | | },
2411 | | );
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
2401 ~ self.inner.alloc_write_and_return_pointer_size(
2402 + host_fn.name(),
2403 + if let Some(outcome) = outcome {
2404 + either::Left(
2405 + iter::once(either::Left([1u8]))
2406 + .chain(iter::once(either::Right(outcome.to_le_bytes()))),
2407 + )
2408 + } else {
2409 + either::Right(iter::once(either::Left([0u8])))
2410 + },
2411 ~ )
|
|
lib/src/executor/host.rs#L2401
warning: unneeded `return` statement
--> lib/src/executor/host.rs:2401:17
|
2401 | / return self.inner.alloc_write_and_return_pointer_size(
2402 | | host_fn.name(),
2403 | | if let Some(outcome) = outcome {
2404 | | either::Left(
... |
2410 | | },
2411 | | );
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
2401 ~ self.inner.alloc_write_and_return_pointer_size(
2402 + host_fn.name(),
2403 + if let Some(outcome) = outcome {
2404 + either::Left(
2405 + iter::once(either::Left([1u8]))
2406 + .chain(iter::once(either::Right(outcome.to_le_bytes()))),
2407 + )
2408 + } else {
2409 + either::Right(iter::once(either::Left([0u8])))
2410 + },
2411 ~ )
|
|
lib/src/executor/runtime_host.rs#L263
warning: use of `format!` to build up a string from an iterator
--> lib/src/executor/runtime_host.rs:263:39
|
263 | let mut key_str = key
| _______________________________________^
264 | | .iter()
265 | | .copied()
266 | | .map(|n| format!("{:x}", n))
267 | | .collect::<String>();
| |____________________________________________^
|
help: call `fold` instead
--> lib/src/executor/runtime_host.rs:266:26
|
266 | .map(|n| format!("{:x}", n))
| ^^^
help: ... and use the `write!` macro here
--> lib/src/executor/runtime_host.rs:266:34
|
266 | .map(|n| format!("{:x}", n))
| ^^^^^^^^^^^^^^^^^^
= note: this can be written more efficiently by appending to a `String` directly
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
= note: `#[warn(clippy::format_collect)]` on by default
|
lib/src/executor/runtime_host.rs#L292
warning: use of `format!` to build up a string from an iterator
--> lib/src/executor/runtime_host.rs:292:43
|
292 | let mut key_str = key
| ___________________________________________^
293 | | .iter()
294 | | .copied()
295 | | .map(|n| format!("{:x}", n))
296 | | .collect::<String>();
| |________________________________________________^
|
help: call `fold` instead
--> lib/src/executor/runtime_host.rs:295:30
|
295 | ... .map(|n| format!("{:x}", n))
| ^^^
help: ... and use the `write!` macro here
--> lib/src/executor/runtime_host.rs:295:38
|
295 | ... .map(|n| format!("{:x}", n))
| ^^^^^^^^^^^^^^^^^^
= note: this can be written more efficiently by appending to a `String` directly
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
|
lib/src/executor/runtime_host.rs#L357
warning: use of `format!` to build up a string from an iterator
--> lib/src/executor/runtime_host.rs:357:22
|
357 | &partial_key
| ______________________^
358 | | .iter()
359 | | .map(|n| format!("{:x}", n))
360 | | .collect::<String>(),
| |____________________________________________^
|
help: call `fold` instead
--> lib/src/executor/runtime_host.rs:359:26
|
359 | .map(|n| format!("{:x}", n))
| ^^^
help: ... and use the `write!` macro here
--> lib/src/executor/runtime_host.rs:359:34
|
359 | .map(|n| format!("{:x}", n))
| ^^^^^^^^^^^^^^^^^^
= note: this can be written more efficiently by appending to a `String` directly
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
|
lib/src/executor/runtime_host.rs#L263
warning: use of `format!` to build up a string from an iterator
--> lib/src/executor/runtime_host.rs:263:39
|
263 | let mut key_str = key
| _______________________________________^
264 | | .iter()
265 | | .copied()
266 | | .map(|n| format!("{:x}", n))
267 | | .collect::<String>();
| |____________________________________________^
|
help: call `fold` instead
--> lib/src/executor/runtime_host.rs:266:26
|
266 | .map(|n| format!("{:x}", n))
| ^^^
help: ... and use the `write!` macro here
--> lib/src/executor/runtime_host.rs:266:34
|
266 | .map(|n| format!("{:x}", n))
| ^^^^^^^^^^^^^^^^^^
= note: this can be written more efficiently by appending to a `String` directly
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
= note: `#[warn(clippy::format_collect)]` on by default
|
lib/src/executor/runtime_host.rs#L292
warning: use of `format!` to build up a string from an iterator
--> lib/src/executor/runtime_host.rs:292:43
|
292 | let mut key_str = key
| ___________________________________________^
293 | | .iter()
294 | | .copied()
295 | | .map(|n| format!("{:x}", n))
296 | | .collect::<String>();
| |________________________________________________^
|
help: call `fold` instead
--> lib/src/executor/runtime_host.rs:295:30
|
295 | ... .map(|n| format!("{:x}", n))
| ^^^
help: ... and use the `write!` macro here
--> lib/src/executor/runtime_host.rs:295:38
|
295 | ... .map(|n| format!("{:x}", n))
| ^^^^^^^^^^^^^^^^^^
= note: this can be written more efficiently by appending to a `String` directly
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
|
lib/src/executor/runtime_host.rs#L357
warning: use of `format!` to build up a string from an iterator
--> lib/src/executor/runtime_host.rs:357:22
|
357 | &partial_key
| ______________________^
358 | | .iter()
359 | | .map(|n| format!("{:x}", n))
360 | | .collect::<String>(),
| |____________________________________________^
|
help: call `fold` instead
--> lib/src/executor/runtime_host.rs:359:26
|
359 | .map(|n| format!("{:x}", n))
| ^^^
help: ... and use the `write!` macro here
--> lib/src/executor/runtime_host.rs:359:34
|
359 | .map(|n| format!("{:x}", n))
| ^^^^^^^^^^^^^^^^^^
= note: this can be written more efficiently by appending to a `String` directly
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
|
The logs for this run have expired and are no longer available.
Loading